Skip to content

Added domain path to all entities#9540

Merged
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:DomainPath
Aug 26, 2024
Merged

Added domain path to all entities#9540
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:DomainPath

Conversation

@harikrishna-patnala
Copy link
Member

@harikrishna-patnala harikrishna-patnala commented Aug 19, 2024 •
edited
Loading

Description

This PR fixes the ticket #8086. Added domain path to all the responses whereever domain and domain names are already used.

Added domain path to all the responses which implements the interfaces ControlledViewEntityResponse and ControlledEntityResponse

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

(localcloud) 🐱 > list virtualmachines filter=name,domainpath,domain
{
"count": 6,
"virtualmachine": [
{
"domain": "ROOT",
"domainpath": "/",
"name": "Vm1N1"
},
{

List of responses where we have added the domain paths are

From ControlledEntityResponse:

ServiceInstanceResponse
KubernetesClusterResponse
ConditionResponse
VpnUsersResponse
StaticRouteResponse
VlanIpRangeResponse
ResourceLimitResponse
AutoScaleVmProfileResponse
RemoteAccessVpnResponse
GuestVlanRangeResponse
ApplicationLoadBalancerResponse
UserDataResponse
AutoScalePolicyResponse
UserVmResponse
GlobalLoadBalancerResponse
VirtualRouterProviderResponse
NetworkResponse
Site2SiteVpnGatewayResponse
LoadBalancerResponse
VpcResponse
UsageRecordResponse
Site2SiteCustomerGatewayResponse
PrivateGatewayResponse
IPAddressResponse
GuestVlanResponse
Site2SiteVpnConnectionResponse
ResourceCountResponse
AcquireIPAddressResponse
AutoScaleVmGroupResponse
VMSnapshotResponse

From ControlledViewEntityResponse

AffinityGroupResponse
TemplateResponse
BucketResponse
EventResponse
SecurityGroupResponse
DomainRouterResponse
VolumeResponse
ResourceTagResponse
InstanceGroupResponse
SnapshotResponse
ProjectInvitationResponse
ProjectAccountResponse

@harikrishna-patnala harikrishna-patnala added this to the 4.19.2.0 milestone Aug 19, 2024
@harikrishna-patnala
Copy link
Member Author

harikrishna-patnala commented Aug 19, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 19, 2024

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@harikrishna-patnala harikrishna-patnala linked an issue Aug 19, 2024 that may be closed by this pull request
add domain path to all entities #8086
Closed
@codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.10345% with 126 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (6e6a276) to head (79c7adc).
Report is 7 commits behind head on 4.19.

Files Patch % Lines
...src/main/java/com/cloud/api/ApiResponseHelper.java 33.33% 6 Missing ⚠️
...che/cloudstack/affinity/AffinityGroupResponse.java 0.00% 3 Missing ⚠️
...udstack/api/response/AcquireIPAddressResponse.java 0.00% 3 Missing ⚠️
.../api/response/ApplicationLoadBalancerResponse.java 0.00% 3 Missing ⚠️
...oudstack/api/response/AutoScalePolicyResponse.java 0.00% 3 Missing ⚠️
...apache/cloudstack/api/response/BucketResponse.java 0.00% 3 Missing ⚠️
...che/cloudstack/api/response/ConditionResponse.java 0.00% 3 Missing ⚠️
.../cloudstack/api/response/DomainRouterResponse.java 0.00% 3 Missing ⚠️
...stack/api/response/GlobalLoadBalancerResponse.java 0.00% 3 Missing ⚠️
...loudstack/api/response/GuestVlanRangeResponse.java 0.00% 3 Missing ⚠️
... and 40 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9540      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
  Complexity    11184    11184              
============================================
  Files          5406     5406              
  Lines        472889   473034     +145     
  Branches      57738    60952    +3214     
============================================
+ Hits          71352    71363      +11     
- Misses       393593   393728     +135     
+ Partials       7944     7943       -1
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.80% <13.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

blueorangutan commented Aug 19, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10692

vishesh92
vishesh92 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

DaanHoogland
DaanHoogland approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

kiranchavala
kiranchavala approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, The domainpath is present in the apiresponses

(cmk) > list networks filter=name,doaminid,domainpath listall=true
{
  "count": 3,
  "network": [
    {
      "domainpath": "/domain2/",
      "name": "test2domain2"
    },
    {
      "domainpath": "/domain1/",
      "name": "account1net"
    },
    {
      "domainpath": "/",
      "name": "test"
    }
  ]
}

(cmk)  > list virtualmachines filter=name,domainid,domainpath listall=true
{
  "count": 3,
  "virtualmachine": [
    {
      "domainid": "12a1d40e-612c-11ef-ba9c-1e0027000437",
      "domainpath": "/",
      "name": "VM-eae4ab5f-c603-4009-a6a5-23130fbf43d7"
    },
    {
      "domainid": "a3dd29d3-243f-44f6-a16b-6248b04cd3eb",
      "domainpath": "/domain1/",
      "name": "vm2"
    },
    {
      "domainid": "a995ca47-c759-4ac2-9447-3d86446a4158",
      "domainpath": "/domain2/",
      "name": "vm3"
    }
  ]
}

@kiranchavala
Copy link
Member

kiranchavala commented Aug 23, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Aug 23, 2024

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Aug 23, 2024

[SF] Trillian test result (tid-11159)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46917 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9540-t11159-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit de3537c into apache:4.19 Aug 26, 2024
@DaanHoogland DaanHoogland deleted the DomainPath branch August 26, 2024 09:04
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 30, 2024
@harikrishna-patnala @dhslove
Added domain path to all entities (apache#9540)
91dc248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

add domain path to all entities

5 participants

@harikrishna-patnala @blueorangutan @kiranchavala @DaanHoogland @vishesh92